Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the graphic design to look more actual #98

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Changed the graphic design to look more actual #98

wants to merge 5 commits into from

Conversation

rocboronat
Copy link

Hi! In order to look like the common apps with emojis like Telegram, Hangouts or Whatsapp, we changed some things:

  • By default, the background of the Fragment is like the official Google Keyboard, instead of an holo gradient.
  • Instead of using alpha to show the selected tab, we're going to tint the picture of the ImageButton. In addition, the apps can define that colours using another newInstance() method. By default, the selected tab will be the common Material Design blue.
  • The emojicons.xml is based in a vertical LinearLayout to improve readability. (sorry about the whole code formatting! Please, ignore the white lines while comparing it)
  • The vertical dividers of the tabs have now disappeared, to meet the last emojicon keyboards style.
  • The minSDK is 8 instead of 7, to support the ImageButton tinting

@rocboronat
Copy link
Author

A picture is worth a thousand words! :·)

2015-12-13 19 57 26

@rockerhieu
Copy link
Owner

Can you rebase your branch?

@rockerhieu
Copy link
Owner

I think we should support customizing theme for this.

@rocboronat
Merge branch 'master' of https://github.com/rockerhieu/emojicon
40fa2ef 
Conflicts:
	emojicon.iml
	example/example.iml
	library/library.iml
	library/src/main/java/com/rockerhieu/emojicon/EmojiconsFragment.java
	library/src/main/res/drawable/ic_emoji_nature_light.xml
	library/src/main/res/drawable/ic_emoji_objects_light.xml
	library/src/main/res/drawable/ic_emoji_people_light.xml
	library/src/main/res/drawable/ic_emoji_places_light.xml
	library/src/main/res/drawable/ic_emoji_recent_light.xml
	library/src/main/res/drawable/ic_emoji_symbols_light.xml
	library/src/main/res/layout/emojicons.xml
	library/src/main/res/values/colors.xml
@rocboronat
Copy link
Author

@rockerhieu done! :·) Someone did a big reformat of the code, didn't it? 👍

@rocboronat
Copy link
Author

@rockerhieu about theming it, for sure it could be a great feature. Right now we did the minimum version to give value to the developer :·) (in this case, us, hehe!)

@gabrielgatu
Copy link

Hi! I am using the 1.3.3 version right now, with gradle, but the theme for the EmojiconsFragment (instantiated with .newInstance(false)) doesn't look like the one that you posted (Still looks like the 1.0 one, but with a dark background - I assume that should have the same color as my keyboard, which is white - default of android 6.0).
Maybe the theme it's implemented in version 1.3.4?

Thank you for this amazing library btw ^_^

@vanniktech
Copy link

👍 this looks really better

@rocboronat
Copy link
Author

Thanks @vanniktech :)

@vanniktech
Copy link

@rocboronat since this has gone very stale (overall the project) and I had some free time I made a fork out of an earlier version of this library: https://github.com/vanniktech/Emoji

Has some new emojis and their categories and also an implementation of Recent Emojis

@rocboronat
Copy link
Author

Thanks @vanniktech! Just read it, two years later 😅

@rocboronat rocboronat mentioned this pull request Jun 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rocboronat @rockerhieu @gabrielgatu @vanniktech