Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signature support #338

Closed
sirwolfgang opened this issue Feb 22, 2021 · 4 comments
Closed

Add signature support #338

sirwolfgang opened this issue Feb 22, 2021 · 4 comments
Labels
enhancement New feature or request Waiting for contribution Waiting for outside contribution to resolve this issue wontfix This will not be worked on

Comments

@sirwolfgang
Copy link

Right now the commits are unsigned, which blocks merge on repos that require signatures.

@robvanderleek
Copy link
Owner

Hi @sirwolfgang

Are you referring to the empty commit created in a (draft) pull request? (such as the commit "Create draft PR" here)

@sirwolfgang
Copy link
Author

@robvanderleek Yeah, I tried to look through it; It looks like the lib supports setting the signature but not familiar enough with the project to make the change.

@robvanderleek robvanderleek added enhancement New feature or request Waiting for contribution Waiting for outside contribution to resolve this issue labels Feb 25, 2021
@robvanderleek
Copy link
Owner

The GitHub library I use does support it indeed. However, I currently manually set the author information when doing the commit and I don't have a signature key for that author. Furthermore, even if I let the GitHub actions bot 🤖 perform the commit it still will not be signed due to this issue.

Unfortunately I see no solution for signing the commits other than waiting for actions/runner#667
Do let me know if you see another way forward.

@stale
Copy link

stale bot commented Apr 23, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Waiting for contribution Waiting for outside contribution to resolve this issue wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants