Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instances Show1, Eq1, Ord1, NFData, Arbitrary, Series? #5

Open
kindaro opened this issue Sep 7, 2020 · 3 comments · May be fixed by #7
Open

Add instances Show1, Eq1, Ord1, NFData, Arbitrary, Series? #5

kindaro opened this issue Sep 7, 2020 · 3 comments · May be fixed by #7
Labels
enhancement New feature or request

Comments

@kindaro
Copy link

kindaro commented Sep 7, 2020

I would like to see some more classes defined for intervals. So far I have had a need of and defined the following:

  • Show1
  • Eq1
  • Ord1
  • NFData
  • Arbitrary
  • Series

It is mostly a triviality to define. I can make a pull request.

Arbitrary and Series incur dependencies that may not be acceptable for the user of the library. Possibly a small companion package can be added to the repository to encompass these.

@robrix
Copy link
Owner

robrix commented Sep 9, 2020

I’m not keen on adding dependencies in general, but companion packages seem totally reasonable. NFData will require a deepseq dependency IIRC, but I don’t think I mind that one.

I don’t recognize Series; what package defines it?

@robrix robrix added the enhancement New feature or request label Sep 9, 2020
@kindaro
Copy link
Author

kindaro commented Sep 10, 2020

Actually it is Serial, my fault.

@kindaro
Copy link
Author

kindaro commented Sep 12, 2020

@robrix  I put forward 2 pull requests, hopefully they are self-explanatory. I propose we move the conversation to the respective pull request tickets #7 and #8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants