Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing .tempLib #367

Merged
merged 2 commits into from
Aug 10, 2021
Merged

Implementing .tempLib #367

merged 2 commits into from
Aug 10, 2021

Conversation

typemytype
Copy link
Member

<font layer glyph>.tempLib is a lib object to store lib data which is not saved into the ufo file, temporary data only available during the life span of the parent object.

Each object which has already an lib got a tempLib: font, layer and glyph

@typemytype
Copy link
Member Author

a PR for fontParts will follow

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2021

Codecov Report

Merging #367 (8601da6) into master (d7828f0) will increase coverage by 1.22%.
The diff coverage is 91.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
+ Coverage   86.15%   87.37%   +1.22%     
==========================================
  Files          57       57              
  Lines       10273    10332      +59     
  Branches     1325     1331       +6     
==========================================
+ Hits         8851     9028     +177     
+ Misses       1059      921     -138     
- Partials      363      383      +20     
Flag Coverage Δ
unittests 87.37% <91.52%> (+1.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
Lib/defcon/objects/font.py 78.41% <70.00%> (+3.24%) ⬆️
Lib/defcon/objects/glyph.py 87.80% <90.00%> (+3.44%) ⬆️
Lib/defcon/objects/layer.py 79.10% <90.00%> (+2.19%) ⬆️
Lib/defcon/test/objects/test_font.py 98.86% <100.00%> (+0.01%) ⬆️
Lib/defcon/test/objects/test_glyph.py 100.00% <100.00%> (ø)
Lib/defcon/test/objects/test_image.py 100.00% <100.00%> (ø)
Lib/defcon/test/objects/test_layer.py 99.13% <100.00%> (+0.02%) ⬆️
Lib/defcon/objects/imageSet.py 81.69% <0.00%> (+1.87%) ⬆️
Lib/defcon/objects/dataSet.py 84.92% <0.00%> (+3.17%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7828f0...8601da6. Read the comment docs.

@typesupply
Copy link
Member

This looks perfect. Thanks!

@typesupply typesupply merged commit b0d339f into master Aug 10, 2021
@benkiel benkiel deleted the tempLib branch August 10, 2021 14:19
anthrotype added a commit to fonttools/ufoLib2 that referenced this pull request Jul 25, 2023
This adds the equivalent of defcon's tempLib to the Font, Layer and Glyph objects.
It's a temporary 'lib' that does not get saved to disk. Can be useful at times (I need this in fontmake right now).

robotools/defcon#367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants