Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos in setup.bat - Windows #1411

Closed
EhsanRanjbari opened this issue May 15, 2023 · 3 comments
Closed

Typos in setup.bat - Windows #1411

EhsanRanjbari opened this issue May 15, 2023 · 3 comments
Assignees
@S-Dafarra

Comments

@EhsanRanjbari
Copy link

I discovered two typos in the setup.bat file as below:

1- https://github.com/robotology/robotology-superbuild/blob/ea59067a8913722bcf829c8fc407a99b51cda4c4/cmake/template/setup.bat.in#LL8C101-L8C101

2- https://github.com/robotology/robotology-superbuild/blob/ea59067a8913722bcf829c8fc407a99b51cda4c4/cmake/template/setup.bat.in#LL17C265-L17C265

in both cases " misplaced. In particular, I discovered the second one when I tried to load the ergoCub model in Gazebo and the path was not added.
@traversaro
Copy link
Member

Thanks! Feel free to open a PR to fix this!

@traversaro
Copy link
Member

traversaro commented Jan 30, 2024 •
edited
Loading

I guess this was fixed by @S-Dafarra in #1588, is this correct @EhsanRanjbari ?

@EhsanRanjbari
Copy link
Author

I guess this was fixed by @S-Dafarra in #1588, is this correct @EhsanRanjbari ?

Yes. Thanks!

Closing the issue as completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@S-Dafarra S-Dafarra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@traversaro @S-Dafarra @EhsanRanjbari