Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document what the ROBOTOLOGY_USES_OCTAVE option is actually installing #138

Open
traversaro opened this issue Nov 22, 2018 · 4 comments
Open

Comments

@traversaro
Copy link
Member

traversaro commented Nov 22, 2018

Currently this option is building:

  • YARP mex-based Octave bindings using yarp-matlab-bindings
  • iDynTree mex-based iDynTree bindings (embedded in iDynTree)

In particular, it would be good to specify that it does not install anything unless ROBOTOLOGY_ENABLE_DYNAMICS is selected.

@traversaro
Copy link
Member Author

cc @InesSorrentino

@isorrentino
Copy link

isorrentino commented Nov 23, 2018

@traversaro and I, have discovered several problems in FindOctave.cmake .


1. In Windows it is not able to find the executable octave-config.

find_program( OCTAVE_CONFIG_EXECUTABLE
              NAMES octave-config
            )

By specifying the path that contains the searched executable, the problem is solved.

find_program( OCTAVE_CONFIG_EXECUTABLE
              HINTS "$ENV{SystemDrive}/Octave/Octave-4.4.1/bin"
              NAMES octave-config
            )

2. It is not able to execute octave-config -p with the option PREFIX (Windows and Linux).

This problem is related to the latest version of Octave (4.4.1) .

execute_process ( COMMAND ${OCTAVE_CONFIG_EXECUTABLE} -p PREFIX
                    OUTPUT_VARIABLE OCTAVE_ROOT_DIR
                    OUTPUT_STRIP_TRAILING_WHITESPACE )

The problem is that in this commit of the cmake community, the options has been changed. Indeed if you execute the command octave-config -h you can check the new options.
To solve this problem for now I substituted the option PREFIX with the option OCTAVE_EXEC_HOME in FindOctave.cmake, but I'll open an issue also on cmake to ask information about this.


3. In Windows since Octave is compiled with MinGW and the MinGW libraries are not compatible with VisualStudio, some libraries of Octave can not be found.

find_library( OCTAVE_OCTINTERP_LIBRARY
              NAMES octinterp liboctinterp
              HINTS ${OCTAVE_LIBRARIES_PATHS}
            )
find_library( OCTAVE_OCTAVE_LIBRARY
              NAMES octave liboctave
              HINTS ${OCTAVE_LIBRARIES_PATHS}
            )
find_library( OCTAVE_CRUFT_LIBRARY
              NAMES cruft libcruft
              HINTS ${OCTAVE_LIBRARIES_PATHS}
            )

@traversaro
Copy link
Member Author

In particular, it would be good to specify that it does not install anything unless ROBOTOLOGY_ENABLE_DYNAMICS is selected.

This is not true after yarp-matlab-bindings have been moved to the Core profile.

@traversaro
Copy link
Member Author

  1. It is not able to execute octave-config -p with the option PREFIX (Windows and Linux).

This was fixed by robotology/ycm-cmake-modules#333 .

  1. In Windows since Octave is compiled with MinGW and the MinGW libraries are not compatible with VisualStudio, some libraries of Octave can not be found.

Related issue: #139 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants