Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split setuptools packaging of gym-ignition and scenario #344

Closed
diegoferigo opened this issue May 6, 2021 · 1 comment · Fixed by #346
Closed

Split setuptools packaging of gym-ignition and scenario #344

diegoferigo opened this issue May 6, 2021 · 1 comment · Fixed by #346

Comments

@diegoferigo
Copy link
Collaborator

It is a while I have this in the back of my mind. For long time now, the pure-Python gym-ignition package and the hybrid C++/Python ScenarIO package are completely independent and can happily live in different repositories. However, from the maintenance point of view, this did not and does not really work well for us.

Another option is having two different setup.py files, one for gym-ignition and another for scenario. After all, the existing gym-ignition package already installs these two folders inside site-package, and it is not a really common pattern.

From the users point of view, nothing really change. The after-split gym-ignition package will depend on the new scenario package, and if anyone from downstream that has gym-ignition in their setup.py file, they will transitively get also the new scenario package.

From our point of view, instead, we should only do minor modifications to our CI/CD pipeline.

From the superbuild point of view (cc @traversaro) there's nothing to change. The CMake project will not be touched.

@diegoferigo
Copy link
Collaborator Author

Closed via #346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment