From db12e58f334b3024d600d6dbcacba5e1921ef89c Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Fri, 27 Sep 2024 22:41:07 -0400 Subject: [PATCH 1/7] Update future cookie a year out (into 2025) As Chrome does not allow for cookie expiry to not go out past a year we need to update each September. This is the update for September 2024. Also left instruction on how to update so next year it is even easier. --- atest/acceptance/keywords/cookies.robot | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/atest/acceptance/keywords/cookies.robot b/atest/acceptance/keywords/cookies.robot index 81e22c453..30d4525d5 100644 --- a/atest/acceptance/keywords/cookies.robot +++ b/atest/acceptance/keywords/cookies.robot @@ -114,12 +114,15 @@ Test Get Cookie Keyword Logging ... domain=localhost ... secure=False ... httpOnly=False - ... expiry=2024-09-15 *:22:33 + ... expiry=2025-09-01 *:25:00 ... extra={'sameSite': 'Lax'} ${cookie} = Get Cookie far_future *** Keywords *** Add Cookies + # To update time each September (as Chrome limits cookies to one year expiry date) use + # import datetime + # print (datetime.datetime.strptime("2025-09-01 12:25:00", "%Y-%m-%d %I:%M:%S").timestamp()) Delete All Cookies Add Cookie test seleniumlibrary ${now} = Get Current Date @@ -127,4 +130,4 @@ Add Cookies ${tomorrow_thistime_datetime} = Convert Date ${tomorrow_thistime} datetime Set Suite Variable ${tomorrow_thistime_datetime} Add Cookie another value expiry=${tomorrow_thistime} - Add Cookie far_future timemachine expiry=1726399353 # 2024-09-15 11:22:33 + Add Cookie far_future timemachine expiry=1756700700 # 2025-09-01 12:25:00 From 473f92560a5683bb7af682b9d55c7f74ff611515 Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Fri, 27 Sep 2024 22:43:34 -0400 Subject: [PATCH 2/7] Updated test matrix to latest version for Python, Robot Framework, and Selenium Update to .. - Python up to now 3.13.0rc2 - Robot Framework from 7.0.1 to 7.1 - Selenium 4.23.1, 4.24.0, 4.25.0 --- .github/workflows/CI.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index d24a0ba01..4f2b5ef22 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -9,9 +9,9 @@ jobs: continue-on-error: true strategy: matrix: - python-version: [3.8, 3.12] # pypy-3.9 - rf-version: [6.1.1, 7.0.1] - selenium-version: [4.21.0, 4.22.0, 4.23.1, 4.24.0] + python-version: [3.8, 3.13.0rc2] # pypy-3.9 + rf-version: [6.1.1, 7.1] + selenium-version: [4.23.1, 4.24.0, 4.25.0] browser: [firefox, chrome, headlesschrome] #edge steps: From 5780c7522edd0bbcac7458ac8493a895e5755c1f Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Sat, 28 Sep 2024 08:02:20 -0400 Subject: [PATCH 3/7] Update to acttions/update-artifacts@v3 --- .github/workflows/CI.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 4f2b5ef22..695ada5ee 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -87,7 +87,7 @@ jobs: # sudo chmod u+x ./selenium-server-standalone.jar # xvfb-run --auto-servernum python atest/run.py --zip headlesschrome --grid True - - uses: actions/upload-artifact@v1 + - uses: actions/upload-artifact@v3 if: failure() with: name: SeleniumLibrary Test results From b077cf22f65841d10138c762c331268591692533 Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Sat, 28 Sep 2024 08:04:25 -0400 Subject: [PATCH 4/7] Corrected Python 3.13 version --- .github/workflows/CI.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 695ada5ee..607c2f9b0 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -9,7 +9,7 @@ jobs: continue-on-error: true strategy: matrix: - python-version: [3.8, 3.13.0rc2] # pypy-3.9 + python-version: [3.8, 3.13.0-rc.2] # pypy-3.9 rf-version: [6.1.1, 7.1] selenium-version: [4.23.1, 4.24.0, 4.25.0] browser: [firefox, chrome, headlesschrome] #edge From 8fbabb8e45bf6b4e9b2ac373ab2678cbaf4e88a3 Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Thu, 31 Oct 2024 20:10:28 -0400 Subject: [PATCH 5/7] Updated Python, Robot Framework and Selenium versions --- .github/workflows/CI.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index d24a0ba01..a89811260 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -9,9 +9,9 @@ jobs: continue-on-error: true strategy: matrix: - python-version: [3.8, 3.12] # pypy-3.9 - rf-version: [6.1.1, 7.0.1] - selenium-version: [4.21.0, 4.22.0, 4.23.1, 4.24.0] + python-version: [3.8, 3.13.0] # pypy-3.9 + rf-version: [6.1.1, 7.1.1] + selenium-version: [4.24.0, 4.25.0 4.26.1] browser: [firefox, chrome, headlesschrome] #edge steps: From c5088368f3df7010f841057d30cae039493610bf Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Thu, 31 Oct 2024 23:10:39 -0400 Subject: [PATCH 6/7] Updated October expired cookies --- atest/acceptance/keywords/cookies.robot | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/atest/acceptance/keywords/cookies.robot b/atest/acceptance/keywords/cookies.robot index 30d4525d5..2349bc68d 100644 --- a/atest/acceptance/keywords/cookies.robot +++ b/atest/acceptance/keywords/cookies.robot @@ -36,15 +36,15 @@ Add Cookie When Secure Is False Should Be Equal ${cookie.secure} ${False} Add Cookie When Expiry Is Epoch - Add Cookie Cookie1 value1 expiry=1730205247 + Add Cookie Cookie1 value1 expiry=1761755100 ${cookie} = Get Cookie Cookie1 - ${expiry} = Convert Date ${1730205247} exclude_millis=True + ${expiry} = Convert Date ${1761755100} exclude_millis=True Should Be Equal As Strings ${cookie.expiry} ${expiry} Add Cookie When Expiry Is Human Readable Data&Time - Add Cookie Cookie12 value12 expiry=2024-10-29 19:36:51 + Add Cookie Cookie12 value12 expiry=2025-10-29 12:25:00 ${cookie} = Get Cookie Cookie12 - Should Be Equal As Strings ${cookie.expiry} 2024-10-29 19:36:51 + Should Be Equal As Strings ${cookie.expiry} 2025-10-29 12:25:00 Delete Cookie [Tags] Known Issue Safari From 5244c9556b58f3103babb888bc1a8b23b83d844b Mon Sep 17 00:00:00 2001 From: Ed Manlove Date: Thu, 31 Oct 2024 23:30:40 -0400 Subject: [PATCH 7/7] Fixed syntax within Selenium versions matrix --- .github/workflows/CI.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index eaf0e49d8..4b246adb8 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -11,7 +11,7 @@ jobs: matrix: python-version: [3.8, 3.13.0] # pypy-3.9 rf-version: [6.1.1, 7.1.1] - selenium-version: [4.24.0, 4.25.0 4.26.1] + selenium-version: [4.24.0, 4.25.0, 4.26.1] browser: [firefox, chrome, headlesschrome] #edge steps: