Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

128-bit integers are available in nightly Rust #2

Closed
FaultyRAM opened this issue Jan 7, 2017 · 4 comments
Closed

128-bit integers are available in nightly Rust #2

FaultyRAM opened this issue Jan 7, 2017 · 4 comments

Comments

@FaultyRAM
Copy link

u128 and i128 were added in rust-lang/rust/pull/38482. They're currently behind the i128_type feature gate.

@robojeb
Copy link
Owner

robojeb commented Feb 25, 2017

I have looked into supporting rust native u128 on nightly but there are some issues with the Rand crate not supporting rand for u128. This prevents implementing Rand for PCG which use the u128.

So for now I think I am going to stick with extprim based u128. If the rand crate implements Rand for u128 behind some feature flag I can look into this issue again.

@TimNN
Copy link

TimNN commented Feb 26, 2017

@robojeb: I'm curious, but why does rand need to support u128 for you to use u128 internally in the pcg implementation?

I think the request here was to just replace the use of extprim::u128 with rust's native u128 type.

@clamydo
Copy link

clamydo commented Mar 14, 2017

For reference rust-random/rand#140

@robojeb
Copy link
Owner

robojeb commented Aug 1, 2018

The latest version of the crate now supports u128 internals.
The big blocker was num-traits support which lets me go to fully generic code instead of lots of macros.

(Sorry I feel I am a bad maintainer, I am not used to being in charge and I have been popping in and out)

@robojeb robojeb closed this as completed Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants