You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here the response.ResponseStream is wrapped in a FixedStream, which is returned to the user. But the FixedStream does not dispose the stream that is given to it.
I'm not sure if this is intentional for a reason that I don't understand, or, if it is a bug, whether the appropriate fix would be to have FixedStream dispose the stream it is passed, or have AwsS3BlobStorage pass a disposeCallback to the FixedStream constructor.
The text was updated successfully, but these errors were encountered:
It appears that when reading from S3, the stream from the
GetObjectResponse
is not disposed.https://github.com/robinrodricks/FluentStorage/blob/develop/FluentStorage.AWS/Blobs/AwsS3BlobStorage.cs#L195
Here the
response.ResponseStream
is wrapped in aFixedStream
, which is returned to the user. But theFixedStream
does not dispose the stream that is given to it.I'm not sure if this is intentional for a reason that I don't understand, or, if it is a bug, whether the appropriate fix would be to have
FixedStream
dispose the stream it is passed, or have AwsS3BlobStorage pass adisposeCallback
to the FixedStream constructor.The text was updated successfully, but these errors were encountered: