Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Possible bug: underlying response stream not disposed #92

Open
timothycoleman opened this issue Nov 20, 2024 · 0 comments
Open

S3 Possible bug: underlying response stream not disposed #92

timothycoleman opened this issue Nov 20, 2024 · 0 comments

Comments

@timothycoleman
Copy link

It appears that when reading from S3, the stream from the GetObjectResponse is not disposed.

https://github.com/robinrodricks/FluentStorage/blob/develop/FluentStorage.AWS/Blobs/AwsS3BlobStorage.cs#L195

Here the response.ResponseStream is wrapped in a FixedStream, which is returned to the user. But the FixedStream does not dispose the stream that is given to it.

I'm not sure if this is intentional for a reason that I don't understand, or, if it is a bug, whether the appropriate fix would be to have FixedStream dispose the stream it is passed, or have AwsS3BlobStorage pass a disposeCallback to the FixedStream constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant