Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception if release is found but no files are included #602

Closed
shahiddev opened this issue Feb 16, 2023 · 0 comments · Fixed by #678
Closed

Throw exception if release is found but no files are included #602

shahiddev opened this issue Feb 16, 2023 · 0 comments · Fixed by #678
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@shahiddev
Copy link

shahiddev commented Feb 16, 2023

Describe the bug
We had an example where downloading the release didn't download any files but the action thought everything was sweet

To Reproduce
Can't repro - likely issue with GH API or some kind of eventual consistency/race condition

Expected behaviour
If downloading a release and no files are found in the release throw an exception

Additional context
It looks like we could tweak the handling of release downloads to warn/throw if a release is found but no files are found in it.
Happy to take a look at doing a PR if that would help - thinking we could tweak the if statement here

@shahiddev shahiddev changed the title Throw exception if release is found but not files are included Throw exception if release is found but no files are included Feb 16, 2023
@robinraju robinraju added good first issue Good for newcomers enhancement New feature or request labels Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants