adds ContinuationToken and extra error handling #20
Conversation
There was a problem hiding this comment.
Thank you so much for your PR! I've added a few comments related to TypeScript mostly. Looks great ✨
Regarding the feature, unfortunately I cannot test it on my end because I don't have a large enough bucket available 🙈 I'm planning on building a suite of E2E tests to automate this (see #21), but for now I'm testing manually.
Just confirming: did you manage to use this version to fetch objects from your bucket with over 1000 objects? I can confirm that the plugin is still behaving as expected for my use cases (multiple buckets with about 500-1000 objects)
Co-Authored-By: Robin Métral <[email protected]>
Co-Authored-By: Robin Métral <[email protected]>
Co-Authored-By: Robin Métral <[email protected]>
Co-Authored-By: Robin Métral <[email protected]>
Co-Authored-By: Robin Métral <[email protected]>
Co-Authored-By: Robin Métral <[email protected]>
|
Thanks for the comments, I've committed those changes. If you find anything else, I'll happily change it. I've tested the code with 1 bucket containing 1500 items. |
There was a problem hiding this comment.
Thank you for addressing the comments @LpmRaven!
Looks great, the TypeScript compiler is just complaining about two small things. After this I'll quickly test again on my end and we'll be good to go!
Co-Authored-By: Robin Métral <[email protected]>
Co-Authored-By: Robin Métral <[email protected]>
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thank you again for your contribution @LpmRaven! Update to version 1.2.0 to use the feature 🙂 |
S3 has a limit of 1000 objects that can be retrieved in a single request. AWS docs
@robinmetral I'm not familiar with writing TS (I should have learnt it by now 🤓) so I would appreciate any input.