Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date/time in DS306 format for eds file (h:mmtt MM-dd-yyyy) should be culture invariant #54

Closed
trojanobelix opened this issue Feb 1, 2017 · 3 comments

Comments

@trojanobelix
Copy link
Contributor

trojanobelix commented Feb 1, 2017

Modify/Creation date and time in DS306 format for eds file (h:mmtt MM-dd-yyyy) should be culture invariant.
E.g. German time would be 10:12 in eds instead of 10:12AM, that is not according DS306 (characters in format „hh:mm(AM|PM)“

Added CultureInfo.InvariantCulture for Creation/Modification date and time.
Unable to push to this repro so her are the changes at line 1230 eds.cs

        fi.CreationDate = fi.CreationDateTime.ToString("MM-dd-yyyy", CultureInfo.InvariantCulture);
        fi.CreationTime = fi.CreationDateTime.ToString("h:mmtt", CultureInfo.InvariantCulture);

        fi.ModificationDate = fi.ModificationDateTime.ToString("MM-dd-yyyy", CultureInfo.InvariantCulture);
        fi.ModificationTime = fi.ModificationDateTime.ToString("h:mmtt", CultureInfo.InvariantCulture);
@trojanobelix trojanobelix changed the title Date/time in DS306 format for eds file (h:mmtt MM-dd-yyyy) should be culture inrevariant Date/time in DS306 format for eds file (h:mmtt MM-dd-yyyy) should be culture invariant Feb 1, 2017
@robincornelius
Copy link
Owner

Thanks for the fix.

If you fork the repo in github, then push to your own copy you can then hit pull request and it gets sent to me and i can pull the changes direct in.

@trojanobelix
Copy link
Contributor Author

Ah ok. Thanks, I will try it.

@robincornelius
Copy link
Owner

Fixed by commit #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants