Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow set a instance folder #52

Open
yodatak opened this issue Oct 16, 2022 · 2 comments
Open

Allow set a instance folder #52

yodatak opened this issue Oct 16, 2022 · 2 comments

Comments

@yodatak
Copy link

yodatak commented Oct 16, 2022

For now the folder instance is created from the instance name , it could be interesting to have a specifiy variable for instance folder different from instance name.

Are you open for a PR ?

@robertdebock
Copy link
Owner

Absolutely open for a PR, go ahead. Don't worry too much if it's good or not, lets start and see what's usable.

@yodatak
Copy link
Author

yodatak commented Oct 18, 2022

The PR i created maybe it could be interesting to change the default and to rename the variables
#53

tomcat_directory: /opt
tomcat_folder: tomcat_8

to
tomcat_install_folder: /opt
tomcat_default_instance_folder: tomcat_8

and mabye latter refactor the varaibles

I test on molecule test in podman and it work for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants