Enable using 'gls' on any OS for ls coloring #4593
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New adopter to omz. I noticed it had aliased
ls
tols --color=tty
despite the check to ensure that this doesn't error-out.In debugging I found that I had already setup
ls
as an aliasalias ls="gls -F --color"
, so the check passes (since the check uses the aliasedls
), and then re-aliasesls
and wipes out thegls
. Tricky.At any rate it seems "more correct" to use
gls
if it's available no matter the OS. I moved the OpenBSD check first to keep the same behavior.I don't have a NetBSD or OpenBSD to test, but I tried with and without
gls
installed on my mac andls
is properly aliased and colored.