Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding calendar for Bins in Custom Component #973

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

robbrad
Copy link
Owner

@robbrad robbrad commented Nov 7, 2024

Adding a calendar type to allow people caldendar entries as well as sensor

@robbrad robbrad merged commit c67a216 into master Nov 7, 2024
3 of 7 checks passed
@robbrad robbrad deleted the feat/calendar branch November 7, 2024 23:53
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 15 lines in your changes missing coverage. Please review.

Project coverage is 72.92%. Comparing base (dde4170) to head (4445d38).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
custom_components/uk_bin_collection/calendar.py 81.35% 11 Missing ⚠️
custom_components/uk_bin_collection/__init__.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #973      +/-   ##
==========================================
+ Coverage   72.52%   72.92%   +0.39%     
==========================================
  Files           8        9       +1     
  Lines         950     1012      +62     
==========================================
+ Hits          689      738      +49     
- Misses        261      274      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m26dvd
Copy link
Contributor

m26dvd commented Nov 8, 2024

@robbrad Awesome work! Just upgraded and calendars work perfectly after reconfiguring my service!

@robbrad
Copy link
Owner Author

robbrad commented Nov 8, 2024

@m26dvd kudos to you tbh. All your hard work on the councils spurred me on to make this integration even better!

I'm working on Alexa now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants