Perform a single request to acquire device _and_ inverter data #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbinjanssen
added
the
enhancement
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
github-actions
bot
added
the
stale
robbinjanssen
added
no-stale
Complements klaasnicolaas/python-omnikinverter#340 Only a single request needs to be performed to retrieve all the necessary data, which is stored in an object and later parsed into a `Device` or `Inverter` `dataclass` when calling the respective function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complements klaasnicolaas/python-omnikinverter#340
Only a single request needs to be performed to retrieve all the
necessary data, which is stored in an object and later parsed into a
DeviceorInverterdataclasswhen calling the respective function.