Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flat config support / ESLint 9 #92

Open
brettz9 opened this issue Jan 17, 2024 · 4 comments · May be fixed by #106
Open

Flat config support / ESLint 9 #92

brettz9 opened this issue Jan 17, 2024 · 4 comments · May be fixed by #106
Labels
modernise Needs doing for evergreenness PRIORITY

Comments

@brettz9
Copy link
Contributor

brettz9 commented Jan 17, 2024

Hi,

As of ESLint 8, there is now a new format for ESLint config files which requires that plugins follow a specific format. In ESLint 9, this format will be the only one available by default (and other API changes have occurred in ESLint 9 that may affect this plugin).

Info:

  1. https://eslint.org/docs/latest/use/configure/configuration-files-new
  2. https://eslint.org/blog/2022/08/new-config-system-part-1/
  3. https://eslint.org/blog/2022/08/new-config-system-part-2/
  4. https://eslint.org/docs/latest/use/configure/migration-guide

Thanks!

@robatwilliams robatwilliams added the modernise Needs doing for evergreenness label Jan 18, 2024
@robatwilliams
Copy link
Owner

Thanks.

Initial rough view of changes required:

Impact:

  • check-es-compat CLI tool users don't care what ESLint version it uses
  • Plugin can probably remain compatible with both ESLint 8 and 9

Would be good to remain under test for both v8 and v9 for a while, unless not it's too much work.

@benasher44
Copy link

The plugin also throws an error if used with FlatConfig compatibility helpers. Even if it doesn't natively support FlatConfig, it would great to fix that in the interim.

@robatwilliams
Copy link
Owner

I'm afraid I have barely any time spare for this project at the moment, and neither am I using this nor ESLint 9.

I see 9 was released 3 weeks ago although of course ideally I would have tested against the beta. But now more and more people will be upgrading.

If someone could post some detail about the problem with the compatibility helpers, it might help me judge whether it's something I could spot-fix when I have half an hour spare.

@Jungzl Jungzl linked a pull request Apr 24, 2024 that will close this issue
@benasher44
Copy link

Actually I take it back. I can't reproduce the crash anymore. If I see it again, I'll come back with a reproduction. Apologies!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modernise Needs doing for evergreenness PRIORITY
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants