We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firstly, I really like this package. Really nice work!
In my app, I want to act based on the fact if the ExecuteJavascriptMiddleware drops a response.
However, this is not registered anywhere besides info logging, resulting in an empty array of items without an exception or event raised.
After digging in, I saw the Downloader class doesn't do anything when noticing a dropped response by a middleware (Downloader.php, line 131-137):
... foreach ($this->middleware as $middleware) { $response = $middleware->handleResponse($response); if ($response->wasDropped()) { return; } } ...
Shouldn't this dispatch a ResponseDropped event or something else?
I'm willing to provide a PR if we can figure out a solution.
Thanks for the help!
The text was updated successfully, but these errors were encountered:
You're right, this is a bug. Thanks for pointing this out!
I will fix this in a future version since there are other things around the ResponseDropped event that aren't working as intended at the moment.
ResponseDropped
Sorry, something went wrong.
ksassnowski
No branches or pull requests
Firstly, I really like this package. Really nice work!
In my app, I want to act based on the fact if the ExecuteJavascriptMiddleware drops a response.
However, this is not registered anywhere besides info logging, resulting in an empty array of items without an exception or event raised.
After digging in, I saw the Downloader class doesn't do anything when noticing a dropped response by a middleware (Downloader.php, line 131-137):
Shouldn't this dispatch a ResponseDropped event or something else?
I'm willing to provide a PR if we can figure out a solution.
Thanks for the help!
The text was updated successfully, but these errors were encountered: