New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix breaking type definition about typescript #215

Merged

Elyx0 merged 3 commits into react-native-documents:master from tkow:feature/for_new_api_type_def

Jul 8, 2019

Contributor

tkow commented Jul 7, 2019

Now index.d.ts has many old breaking types.
I fixed,

filetype -> type
multiple -> disable to inpute

then I add type check test and strict type args by union literal types.

tkow added 3 commits

July 7, 2019 23:57


          enable check type file at vscode and recover latest type

3dce452


          add test case

282f289


          fix isCancel type to boolean and add new error type test

3e3521e

Elyx0 merged commit 5d74cb5 into react-native-documents:master

Collaborator

Elyx0 commented Jul 8, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet