Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: 🔧 fix SSR rendering on remote envs #13

Merged
merged 18 commits into from
Apr 28, 2022
Merged

build: 🔧 fix SSR rendering on remote envs #13

merged 18 commits into from
Apr 28, 2022

Conversation

rmzNadir
Copy link
Owner

@rmzNadir rmzNadir commented Apr 28, 2022 •
edited
Loading

Description:

  • Switch to Netlify as hosting provider
  • In the end opting for a polyfill solution ended up being the best since switching to Netlify and using a newer Node version that supports AbortController out of the box didn't work even when combining it with this fix (Apparently it isn't the problem in this case)

How to test this functionality?

  • Checkout the shipment details page!

Does this PR include unit tests?

  • Yes
  • No: Not required

@vercel
Copy link

vercel bot commented Apr 28, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
shipment-service-selector ✅ Ready (Inspect) Visit Preview Apr 28, 2022 at 11:06PM (UTC)

@netlify
Copy link

netlify bot commented Apr 28, 2022 •
edited
Loading

✅ Deploy Preview for lighthearted-pie-de706e ready!

Name Link
🔨 Latest commit 54b1608
🔍 Latest deploy log https://app.netlify.com/sites/lighthearted-pie-de706e/deploys/626b1d73111851000875f6a3
😎 Deploy Preview https://deploy-preview-13--lighthearted-pie-de706e.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rmzNadir rmzNadir changed the title build: 🔧 remove i18n config build: 🔧 fix SSR rendering on remote envs Apr 28, 2022
@rmzNadir rmzNadir self-assigned this Apr 28, 2022
@rmzNadir rmzNadir merged commit b0450f3 into master Apr 28, 2022
@rmzNadir rmzNadir deleted the build/switch-to-netlify branch April 28, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rmzNadir rmzNadir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rmzNadir