Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with new pip resolver #1895

Closed
ryanjulian opened this issue Aug 13, 2020 · 5 comments
Closed

Test with new pip resolver #1895

ryanjulian opened this issue Aug 13, 2020 · 5 comments
Assignees
Milestone

Comments

@ryanjulian
Copy link
Member

@ryanjulian ryanjulian added this to the v2020.09rc4 milestone Aug 13, 2020
@gitanshu
Copy link
Contributor

(I know this is meant for an automated test)

I tried it last week, this seems to be the only problem.

ERROR: Cannot install garage[mujoco] 2020.9.0rc2.dev0 and gym[all] 0.17.2 because these package versions have conflicting dependencies.

The conflict is caused by:
    garage[mujoco] 2020.9.0rc2.dev0 depends on mujoco-py<2.1 and >=2.0
    gym[all] 0.17.2 depends on mujoco-py<2.0 and >=1.50; extra == "all"

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip attempt to solve the dependency conflict

ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/user_guide/#fixing-conflicting-dependencies

@krzentner
Copy link
Contributor

How hard would it be for us to not require mujoco 2.0? I'm not too familiar with what's different between the versions, but it seems we don't have that much mujoco specific code (besides tests).

@gitanshu
Copy link
Contributor

pip 20.2.4 was released couple days ago and pip install --use-feature=2020-resolver garage[all] is stuck in a loop now. Relevant issue on pip's issue tracker: pypa/pip#9011

@ryanjulian
Copy link
Member Author

Different versions of MuJoCo can lead to different benchmark results (e.g. friction behavior can change), so it's important to specify.

Our main direct MuJoCo dependency is in garage.envs.mujoco, but it would be nice to remove those in the future in favor of some other standardized library of meta-RL environments.

@ryanjulian ryanjulian modified the milestones: v2020.10.0, v2020.12.0 Oct 30, 2020
@gitanshu
Copy link
Contributor

gitanshu commented May 9, 2021

Closing this. As far as I can tell, this is working fine now.

@gitanshu gitanshu closed this as completed May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants