New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen endpoint regex to allow to s3-compatible services #142

Open

perrygeo opened this issue Sep 17, 2019 · 0 comments

perrygeo commented Sep 17, 2019

The current regex prohibits using third-party (non-aws) services which implement the S3 API

s3gof3r/s3gof3r.go

Line 21 in 864ae0b

    
           var regionMatcher = regexp.MustCompile("s3[-.]([a-z0-9-]+).amazonaws.com([.a-z0-9]*)")

Is there a reason to limit gof3r to strictly amazon services? Or could the regex be loosened to accept any valid URL?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment