Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Inbound Fees when LND 18 is released. #63

Open
ziggie1984 opened this issue Mar 31, 2024 · 3 comments
Open

Support Inbound Fees when LND 18 is released. #63

ziggie1984 opened this issue Mar 31, 2024 · 3 comments

Comments

@ziggie1984
Copy link
Contributor

See for reference:

  1. htlcswitch: add inbound routing fees receive support lightningnetwork/lnd#6703
    and
  2. routing: inbound fees send support lightningnetwork/lnd#6934

Maybe we also need to wait for the buildroute command as well:

  1. router: inbound fees support for BuildRoute lightningnetwork/lnd#7060
@Bitcoinite
Copy link

bump this. I recently started using regolancer again and would really like to use the new inbound fee discounts

@rkfg
Copy link
Owner

rkfg commented Jul 7, 2024

I suppose we need lnd to support building such routes first. I'd really suggest against manually doing this because the logic is complex enough and these rules might change in the future. For example, if/when lnd supports total negative inbound fees, that is when you agree to pay for inbound discounting it below zero. This kind of logic should always be on the lnd side.

@feelancer21
Copy link

@Bitcoinite What feature are you missing? For inbound discounts I don't see any todos on the regolancer side. QueryRoutes of lnd supports inbound fees, but not BuildRoute. That means when using the rapid rebalancer you can have a situation, that the first payment supports inbound discounts, but the following payments not. But BuildRoute should be fixed with the next lnd version.

lightningnetwork/lnd#8886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants