Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oneOf{const,title} reorders boolean options unlike enum/enumNames #782

Closed
2 tasks done
mfulton26 opened this issue Dec 4, 2017 · 2 comments
Closed
2 tasks done

Comments

@mfulton26
Copy link
Contributor

Prerequisites

  • I have read the documentation;
  • In the case of a bug report, I understand that providing a SSCCE example is tremendously useful to the maintainers.

Description

Bug

Steps to Reproduce

  1. Define a schema with a boolean type property
  2. Define an enum using the alternative oneOf{const,title} for that boolean type with false before true in the array
  3. Render the form and note how the options have been reordered. 😢

Here is a shared playground link demonstrating the issue.

Expected behavior

Order of boolean options can be controlled

Actual behavior

Order of boolean options cannot be controled

Version

You can usually get this information in your package.json or in the file URL if you're using the unpkg one.

1.0.0

@glasserc
Copy link
Contributor

Both this and #781 seem like legitimate bugs and I would be happy to review a PR to fix them.

@pushred
Copy link
Contributor

pushred commented Jan 19, 2019

@glasserc I've opened a PR that fixes these issues as well as #945, please review #1137

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants