Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Properties icons are not working when using Bootstrap 4 #1434

Closed
pedroth opened this issue Aug 27, 2019 · 4 comments
Closed

Additional Properties icons are not working when using Bootstrap 4 #1434

pedroth opened this issue Aug 27, 2019 · 4 comments

Comments

@pedroth
Copy link

pedroth commented Aug 27, 2019

Description

Additional Properties icons are not working when using Bootstrap 4.

This happens because Bootstrap 4, removed glyphicons.

Steps to Reproduce

  1. Use Bootstrap 4, instead of 3
  2. Create a form with Additional Properties

Expected behavior

Icons should appear when creating a form with Additional Properties

Actual behavior

Icons don't appear when creating a form with Additional Properties

Version

"react-jsonschema-form": "^1.6.1"

@epicfaace
Copy link
Member

The solution to this eventually is to create a Bootstrap 4 theme using the withTheme component.

Might there be a short-term solution to this that would make the default icons work even in bootstrap 4?

@C-odes
Copy link

C-odes commented Sep 3, 2019

My project uses bootstrap 4, this library requires bootstrap 3. Is there any way to make it work with only 4?

@cefn
Copy link

cefn commented Sep 8, 2019

I was able to add glyphicons by including this in my source. That doesn't mean it is 'working' as I have only tested it in a limited way.

<link href="//netdna.bootstrapcdn.com/bootstrap/3.0.0/css/bootstrap-glyphicons.css" rel="stylesheet">

@epicfaace
Copy link
Member

There are other issues with using bootstrap 4 with the current default react-jsonschema-form theme, such as the array buttons not showing up either. I'm merging this issue with #1455.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants