From 83657ba31ed6e5f958f328af0d1246b6498c4cf0 Mon Sep 17 00:00:00 2001 From: Richard Meitern Date: Tue, 11 Apr 2023 15:28:48 +0300 Subject: [PATCH] changed citation style --- .travis.yml | 7 +++---- README.md | 2 +- cran-comments.md | 28 ++++++++++++++++------------ inst/CITATION | 24 +++++++++++------------- 4 files changed, 31 insertions(+), 30 deletions(-) diff --git a/.travis.yml b/.travis.yml index 8899356..c1ce2ae 100644 --- a/.travis.yml +++ b/.travis.yml @@ -14,8 +14,9 @@ r: r_packages: - remotes -r_github_packages: - - harrelfe/Hmisc + - Hmisc + - rms + - covr addons: apt: @@ -25,8 +26,6 @@ addons: # warnings are errors warnings_are_errors: true -r_packages: - - covr after_success: - Rscript -e 'library(covr); codecov()' diff --git a/README.md b/README.md index 1bc1f50..0ad8516 100644 --- a/README.md +++ b/README.md @@ -3,7 +3,7 @@ [![CRAN Status Badge](http://www.r-pkg.org/badges/version/ormPlot)](https://cran.r-project.org/package=ormPlot) [![Build Status](https://travis-ci.com/rix133/ormPlot.svg?branch=master)](https://app.travis-ci.com/github/rix133/ormPlot) -[![Codecov test coverage](https://codecov.io/gh/rix133/ormPlot/branch/master/graph/badge.svg)](https://codecov.io/gh/rix133/ormPlot?branch=master) +[![Codecov test coverage](https://codecov.io/gh/rix133/ormPlot/branch/master/graph/badge.svg)](https://app.codecov.io/gh/rix133/ormPlot?branch=master) # Plotting ordinal regression models from R package rms diff --git a/cran-comments.md b/cran-comments.md index dd6ebb2..c8f0ae0 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,23 +1,27 @@ ## Resubmission -Can now plot lrm models similary to orm +Can now plot lrm models similar to orm. Fixes citation style issues and readme +links. ## Test environments -* Local windows 10 install, R 4.0.3 -* Travis-ci linux xenial, (r-devel, r-rel, r-oldrel) +In addition to the local windows 10 R 4.1.3, I used the devtools::check_rhub() +and devtools devtools::check_win_release() to check the package on multiple +platforms. The list with results: + +* Local windows 10 install, R-oldrel +* Travis-ci linux focal, (r-devel, r-rel, r-oldrel) https://app.travis-ci.com/github/rix133/ormPlot +* Windows Server 2022, R-rel, https://win-builder.r-project.org/2vPrCrm8aB74/ +* R-Hub Windows Server 2022, R-devel +https://builder.r-hub.io/status/ormPlot_0.3.5.tar.gz-b272059b81934e78a4b0958acbc84608 * R-hub Windows Server 2008 R2 SP1, R-devel, 32/64 bit (r-devel) * R-hub Fedora Linux, R-devel, clang, gfortran (r-devel) -* Ubuntu Linux 16.04 LTS, R-release, GCC (r-rel) ## R CMD check results -There were 0 NOTE, 0 ERRORs and 0 WARNINGs. on most platforms. However, -On R-hub Fedora Linux, R-devel, clang, gfortran (r-devel) -There was one NOTE: Examples with CPU (user + system) or elapsed time > 5s -On Ubuntu Linux 16.04 LTS, R-release, GCC (r-rel) -ERROR: can't install suggested package 'vdiffr' -However, this issue does not appear if variable _R_CHECK_FORCE_SUGGESTS_ is set -to false. Hence, I belive there is nothing else I can to if I want to keep the -tests. +There were some notes warnings or errors in some platforms. However the checks +from https://win-builder.r-project.org/ were all OK. The Travis-ci fails due to +failure to install Hmisc. (Nothing I can do there). The Rhub Windows fails due +to some tests failing because of API mismatch on svglite (I could remove these +tests). ## Downstream dependencies diff --git a/inst/CITATION b/inst/CITATION index 882faa3..9fbdfe2 100644 --- a/inst/CITATION +++ b/inst/CITATION @@ -1,17 +1,15 @@ citHeader("To cite ormPlot or the bundled data in publications, please use:") -citEntry(entry = "Article", - title = "Morphometric traits predict educational attainment independently of socioeconomic background", - author = personList(as.person("Markus Valge"), - as.person("Richard Meitern"), - as.person("Peeter Hõrak")), - journal = "BMC public health", - year = "2019", - volume = "19", - number = "1", - pages = "1696", - url = "https://doi.org/10.1186/s12889-019-8072-7", - - textVersion ="Valge, M., Meitern, R. & Hõrak, P. Morphometric traits predict educational attainment independently of socioeconomic background. BMC Public Health 19, 1696 (2019). https://doi.org/10.1186/s12889-019-8072-7" +bibentry( + bibtype = "Article", + title = "Morphometric traits predict educational attainment independently of socioeconomic background", + author = c(person("Markus", "Valge"), person("Richard", "Meitern"), person("Peeter", "Hõrak")), + journal = "BMC public health", + year = "2019", + volume = "19", + number = "1", + pages = "1696", + url = "https://doi.org/10.1186/s12889-019-8072-7", + textVersion = "Valge, M., Meitern, R. & Hõrak, P. Morphometric traits predict educational attainment independently of socioeconomic background. BMC Public Health 19, 1696 (2019). https://doi.org/10.1186/s12889-019-8072-7" )