-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add manual torrent adding #785
Conversation
@dreulavelle @filiptrplan It downloads the correct thing, but it doesn't seem to symlink it. I'm adding a new symlink event at the end, what could the problem be? |
src/controllers/items.py
Outdated
|
||
session.commit() | ||
|
||
request.app.program.em.add_event(Event("Symlinker", item)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we handle by id's now, so when the id_handling branch is done this will need to change to item._id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah this still needs fixing I believe
src/controllers/items.py
Outdated
@@ -385,7 +458,8 @@ class SetTorrentRDResponse(BaseModel): | |||
def add_torrent(request: Request, id: int, magnet: str) -> SetTorrentRDResponse: | |||
torrent_id = "" | |||
try: | |||
torrent_id = add_torrent_magnet(magnet) | |||
_, infohash = get_type_and_infohash(magnet) | |||
torrent_id = add_torrent(infohash) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will fail for AllDebrid :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that we should refactor some things related to the manual torrent adding when we merge #762 so we have a standard interface for the downloaders.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fully agree!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs looked at again.
c71adee
to
51b64e4
Compare
27ac133
to
c80a064
Compare
c18faed
to
5e33c9c
Compare
chore: remove not needed state transition
5e33c9c
to
27d5643
Compare
Pull Request Check List
Resolves: #issue-number-here
Description: