Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add manual torrent adding #785

Merged
merged 3 commits into from
Oct 26, 2024
Merged

Conversation

davidemarcoli
Copy link
Collaborator

Pull Request Check List

Resolves: #issue-number-here

  • Added tests for changed code.
  • Updated documentation for changed code.

Description:

@davidemarcoli
Copy link
Collaborator Author

@dreulavelle @filiptrplan It downloads the correct thing, but it doesn't seem to symlink it. I'm adding a new symlink event at the end, what could the problem be?


session.commit()

request.app.program.em.add_event(Event("Symlinker", item))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we handle by id's now, so when the id_handling branch is done this will need to change to item._id

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this still needs fixing I believe

@@ -385,7 +458,8 @@ class SetTorrentRDResponse(BaseModel):
def add_torrent(request: Request, id: int, magnet: str) -> SetTorrentRDResponse:
torrent_id = ""
try:
torrent_id = add_torrent_magnet(magnet)
_, infohash = get_type_and_infohash(magnet)
torrent_id = add_torrent(infohash)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fail for AllDebrid :/

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should refactor some things related to the manual torrent adding when we merge #762 so we have a standard interface for the downloaders.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fully agree!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs looked at again.

@davidemarcoli davidemarcoli force-pushed the feature/manual-torrent-adding branch 2 times, most recently from c71adee to 51b64e4 Compare October 19, 2024 11:01
@dreulavelle dreulavelle changed the title Add manual torrent adding feat: add manual torrent adding Oct 26, 2024
@davidemarcoli davidemarcoli marked this pull request as ready for review October 26, 2024 13:25
@dreulavelle dreulavelle merged commit acb22ce into main Oct 26, 2024
3 checks passed
@dreulavelle dreulavelle deleted the feature/manual-torrent-adding branch October 26, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants