You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Why don't you ask the user to create a token for authentication (like every other github-cli)? At least give me the choice to input it directly.
That way it's much easier for the application (less points of failure) and it's much more secure for the user (tokens are easily revokable, you don't get their password).
And your authentication process is broken for me (both token as password and password):
$ node -v
v10.5.0
$npm -v
6.2.0
$ starring
Your GitHub username: jneidel
Your GitHub password: ✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔✔
(node:25425) TimeoutOverflowWarning: 4294967296000 does not fit into a 32-bit signed integer.
Timer duration was truncated to 2147483647.
(node:25425) TimeoutOverflowWarning: 4294967296000 does not fit into a 32-bit signed integer.
Timer duration was truncated to 2147483647.
/home/jneidel/.bin/node-10.5.0/lib/node_modules/starring/dist/cli.js:134
var _ref3 = _asyncToGenerator(function* (err, { token }) {
^
TypeError: Cannot destructure property `token` of 'undefined' or 'null'.
at /home/jneidel/.bin/node-10.5.0/lib/node_modules/starring/dist/cli.js:134:42
at /home/jneidel/.bin/node-10.5.0/lib/node_modules/starring/dist/cli.js:63:68
at ghAuth (/home/jneidel/.bin/node-10.5.0/lib/node_modules/starring/dist/cli.js:153:16)
at afterCreateAuth (/home/jneidel/.bin/node-10.5.0/lib/node_modules/starring/node_modules/ghauth/ghauth.js:155:16)
at BufferList.afterCreateAuthResponse [as _callback] (/home/jneidel/.bin/node-10.5.0/lib/node_modules/starring/node_modules/ghauth/ghauth.js:42:14)
at BufferList.end (/home/jneidel/.bin/node-10.5.0/lib/node_modules/starring/node_modules/bl/bl.js:98:10)
at DuplexWrapper.onend (/home/jneidel/.bin/node-10.5.0/lib/node_modules/starring/node_modules/duplexer2/node_modules/readable-stream/lib/_stream_readable.js:537:10)
at Object.onceWrapper (events.js:273:13)
at DuplexWrapper.emit (events.js:187:15)
at /home/jneidel/.bin/node-10.5.0/lib/node_modules/starring/node_modules/duplexer2/node_modules/readable-stream/lib/_stream_readable.js:934:16
The text was updated successfully, but these errors were encountered:
Why don't you ask the user to create a token for authentication (like every other github-cli)? At least give me the choice to input it directly.
That way it's much easier for the application (less points of failure) and it's much more secure for the user (tokens are easily revokable, you don't get their password).
And your authentication process is broken for me (both token as password and password):
The text was updated successfully, but these errors were encountered: