Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete example/instruction #63

Closed
Edo78 opened this issue Nov 11, 2020 · 3 comments
Closed

Incomplete example/instruction #63

Edo78 opened this issue Nov 11, 2020 · 3 comments
Labels

Comments

@Edo78
Copy link

Edo78 commented Nov 11, 2020

I'm trying to check if I can make this works but I found a minor issue and a bigger one looking at the example https://rithvikvibhu.github.io/GHLocalApi/#section/Google-Home-Local-API/Example

The minor one is that isn't reported jq as a prerequisite.

The bigger one is that I can't find any info about the content of /path/to/protos in

./grpcurl -H 'authorization: Bearer ya29.a0Af****' \
  -import-path /path/to/protos \
  -proto /path/to/protos/google/internal/home/foyer/v1.proto \
  googlehomefoyer-pa.googleapis.com:443 \
  google.internal.home.foyer.v1.StructuresService/GetHomeGraph | jq '.home.devices[] | {deviceName, localAuthToken}'

I was lucky enought to find #39 (comment)

I don't know why the protos aren't available or mentioned elsewere (that I can found) but it was pretty hard to figure it out as I never user grpcurl

I think that the instruction should be updated. Let me know if I can work on a PR

@rithvikvibhu
Copy link
Owner

isn't reported jq as a prerequisite

Ah yes, I think there was another issue about jq not being installed. Will add a comment with each example.

can't find any info about the content of /path/to/protos

The drive link is listed under prerequisites. Maybe adding a note that /path/to/protos/ should point to the Proto files folder will clear things up.
image

@rithvikvibhu
Copy link
Owner

Let me know if I can work on a PR

Yes, please. I'll merge it when you make one.

@stale
Copy link

stale bot commented Nov 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 25, 2020
@stale stale bot closed this as completed Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants