Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: MemoryManager uses CN memory allocation for total_memory #19472

Closed
fuyufjh opened this issue Nov 20, 2024 · 0 comments · Fixed by #19477
Closed

bug: MemoryManager uses CN memory allocation for total_memory #19472

fuyufjh opened this issue Nov 20, 2024 · 0 comments · Fixed by #19477
Assignees
Milestone

Comments

@fuyufjh
Copy link
Member

fuyufjh commented Nov 20, 2024

Here we assumed that the total memory of CN is only used for 3 portions: compute, storage and reserve.

// NOTE: Due to some limits, we use `compute_memory_bytes + storage_memory_bytes` as
// `total_compute_memory_bytes` for memory control. This is just a workaround for some
// memory control issues and should be modified as soon as we figure out a better solution.
//
// Related issues:
// - https://github.com/risingwavelabs/risingwave/issues/8696
// - https://github.com/risingwavelabs/risingwave/issues/8822
let memory_mgr = MemoryManager::new(MemoryManagerConfig {
total_memory: compute_memory_bytes + storage_memory_bytes,

However, the standalone node breaks this assumption. This will cause the MemoryManager to use less memory than expected.

@fuyufjh fuyufjh self-assigned this Nov 20, 2024
@github-actions github-actions bot added this to the release-2.2 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant