Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate postgres sink from jdbc to rust implementation using tokio_postgres #19213

Closed
Tracked by #16745
kwannoel opened this issue Oct 30, 2024 · 3 comments
Closed
Tracked by #16745
Milestone

Comments

@kwannoel
Copy link
Contributor

No description provided.

@github-actions github-actions bot added this to the release-2.2 milestone Oct 30, 2024
@BugenZhao
Copy link
Member

Shall we consider sqlx or sea-query (with sea-schema), which is database agnostic just like jdbc?

@kwannoel
Copy link
Contributor Author

Shall we consider sqlx or sea-query (with sea-schema), which is database agnostic just like jdbc?

I did consider it. But sqlx more complicated to use compared to tokio_postgres, and the interfaces are not as intuitive. Additionally we have distinct logic like the kind of prepared statements we run, which can be different across different SQL databases.

I implement them with native libraries first since it's simpler. We can further abstract it with sqlx if necessary.

@kwannoel
Copy link
Contributor Author

We just need to:

  1. Do more testing.
  2. Switch jdbc:postgres to native postgres sink by changing the default system variable: feat(common): support switching from pg jdbc to pg native sinks #19703

@kwannoel kwannoel modified the milestones: release-2.2, release-2.3 Dec 27, 2024
@kwannoel kwannoel closed this as completed Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants