Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): add sqlplannertest #661

Merged
merged 4 commits into from
Jun 13, 2022
Merged

feat(test): add sqlplannertest #661

merged 4 commits into from
Jun 13, 2022

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jun 9, 2022

Signed-off-by: Alex Chi [email protected]

As title. It's a really big change :)

Basically, we will need to run make apply_planner_test and add the latest planner test result into the git repo.

This PR also fixes some issues about disk I/O in in-memory mode. #660 should further fix this.

@skyzh skyzh requested a review from wangrunji0408 June 9, 2022 15:27
Signed-off-by: Alex Chi <[email protected]>
Copy link
Member

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I didn't review the storage part. Not very familiar to me. 😇
And I'm still wondering if it's possible to integrate sqlplannertest into sqllogictest.

tests/sqlplannertest/Cargo.toml Show resolved Hide resolved
tests/sqllogictest/src/lib.rs Show resolved Hide resolved
docs/05-e2e-tests.md Outdated Show resolved Hide resolved
tests/planner_test/count.yml Show resolved Hide resolved
@skyzh skyzh disabled auto-merge June 13, 2022 04:56
Co-authored-by: Runji Wang <[email protected]>

Signed-off-by: Alex Chi <[email protected]>
Co-authored-by: Runji Wang <[email protected]>

Signed-off-by: Alex Chi <[email protected]>
@wangrunji0408 wangrunji0408 merged commit 8929f62 into main Jun 13, 2022
@wangrunji0408 wangrunji0408 deleted the skyzh/add-planner-test branch June 13, 2022 12:44
xinchengxx pushed a commit to xinchengxx/risinglight that referenced this pull request Jul 12, 2022
* feat(test): add sqlplannertest

Signed-off-by: Alex Chi <[email protected]>

* add print task type

Signed-off-by: Alex Chi <[email protected]>

* Update docs/05-e2e-tests.md

Co-authored-by: Runji Wang <[email protected]>

Signed-off-by: Alex Chi <[email protected]>

* Update tests/planner_test/count.yml

Co-authored-by: Runji Wang <[email protected]>

Signed-off-by: Alex Chi <[email protected]>
Signed-off-by: xinchengforgit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants