Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work with BitManip TG to ensure they have groupings that work forCrypto #40

Closed
grnewell opened this issue Aug 27, 2020 · 5 comments
Closed
Labels
Feature Groups Anything to do with the feature groups / sets / marketing / branding strings.

Comments

@grnewell
Copy link

Crypto TG needs to work with BitManip TG on instruction groupings for the "naming/branding" strings. For us (Crypto) it is important that the BitManip groupings can be used to make sure that the instructions we are "borrowing" from them can be succintly express in their naming strings. We also need to make sure that their CLMUL instruction is constant-time (i.e., latency is data independent, as a minimum leakage-related requirement).

@ben-marshall
Copy link
Member

We should certainly keep up communication with Bitmanip, but - would it be easier to just define a "feature string" which refers to "All of the Bitmanip instructions which are used by crypto"? That way we only need to worry about picking a unique name for it, rather than having to depend on them for anything. I'd assumed that all of the Bitmanip-borrowed instructions would just come as a single group, but am happy to be convinced otherwise.

About the constant time aspect of CLMUL - This is already expressed in the draft crypto spec. Perhaps asking Claire to note this as an issue would be sensible?

@ben-marshall ben-marshall added the Feature Groups Anything to do with the feature groups / sets / marketing / branding strings. label Aug 28, 2020
@grnewell
Copy link
Author

I suggested this approach (i.e., going it alone) to Mark and indicated he would rather BitManip. TG provide all the groupings of their instructions... even those groupings we see as essential.

@ben-marshall
Copy link
Member

Hmm. I don't think that's the best way round IMHO. Better to let Bitmanip define the most sensible groupings for Bitmanip and let us do the same for Crypto. Otherwise you get unnecessary weird inter-dependencies between TGs.

By borrowing instructions from Bitmanip, we've already broken the notion that there is a 1-to-1 correspondence between an instruction and the extension it belongs too. Since sharing instructions between extensions is sensible, forcing ownership of issues around those instructions on only the TG which originally defined it doesn't make sense like it did before.

I may be preaching to the choir now.

@grnewell
Copy link
Author

We (i.e., Crypto TG) are now taking the reins an proposing a named instruction group ("Zkb") for the bit-manipulation instructions we borrow from the Bit Manipulation TG. A JIRA ticket has been filed as an "FYI" to the Bit-Manip TG.

@ben-marshall
Copy link
Member

As decided at meeting 23/oct/2020 - closing all feature-group related issues and tracking in Jira.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Groups Anything to do with the feature groups / sets / marketing / branding strings.
Projects
None yet
Development

No branches or pull requests

2 participants