Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should c.srli, c.srai, and c.slli be part of Zkt on RV64? #149

Closed
topperc opened this issue Jan 17, 2022 · 2 comments
Closed

Should c.srli, c.srai, and c.slli be part of Zkt on RV64? #149

topperc opened this issue Jan 17, 2022 · 2 comments

Comments

@topperc
Copy link
Contributor

topperc commented Jan 17, 2022

As far as I know these instructions are valid on RV64. Should they be part of Zkt? This appears to have been noted in the Arch Review Chapter 5 here https://wiki.riscv.org/download/attachments/350001/Scalar%20Crypto%20Arch%20Review%20Results.pdf
@mjosaarinen
Copy link
Collaborator

Yes, they absolutely should be there. They were in the earliest proposals https://github.com/rvkrypto/riscv-zkt-list/blob/main/zkt-list.adoc but somehow got lost along the way.

( I think this has happened due to a request to remove the RV128 instructions C.SRLI64, C.SRAI64, and C.SLLI64 -- this was interpreted as removal of C.SRLI & co from RV64 somehow. )

@mjosaarinen mjosaarinen mentioned this issue Jan 27, 2022
Merged
@ben-marshall
Copy link
Member

The fix for this has now been released in v1.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ben-marshall @mjosaarinen @topperc