Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breakpoint.s undesired behavior when trigger does not exist? #32

Closed
debs-sifive opened this issue Jan 26, 2019 · 1 comment · Fixed by #101
Closed

breakpoint.s undesired behavior when trigger does not exist? #32

debs-sifive opened this issue Jan 26, 2019 · 1 comment · Fixed by #101

Comments

@debs-sifive
Copy link
Contributor

When a trigger doesn't exist, the test goes to the pass label. The result is that the signature is not written to after the trigger check, and the target will fail make verify. This doesn't seem like the ideal action, since it's valid for a target to have no trigger.

For context, I'm trying to add rocket chip's Default[RV32]Config as a target, and it only has one trigger.

@debs-sifive debs-sifive mentioned this issue Jan 29, 2019
5 tasks
debs-sifive added a commit to debs-sifive/riscv-compliance that referenced this issue Feb 5, 2019
debs-sifive added a commit to debs-sifive/riscv-compliance that referenced this issue Feb 5, 2019
debs-sifive added a commit to debs-sifive/riscv-compliance that referenced this issue Feb 6, 2019
debs-sifive added a commit to debs-sifive/riscv-compliance that referenced this issue Feb 6, 2019
debs-sifive added a commit to debs-sifive/riscv-compliance that referenced this issue Feb 15, 2019
@allenjbaum
Copy link
Collaborator

IF this has been fixed, can we close the issue?

@neelgala neelgala mentioned this issue Mar 19, 2020
neelgala added a commit that referenced this issue Mar 25, 2020
Changes in this pull-request:

    * restructuring the riscv-test-suite to indicate clearly what is deprecated, wip and usable
      tests.
    * based on the above fixed the directory structure for riscv-targets where-ever applicable. Only
      tested riscvOVPsim and spike.
    * fixed script bugs for spike as well
    * renamed rv32i/I-IO.S to rv32i/I-IO-01.S along with necessary changes to the reference files
      and Makefrag
    * renamed mbadaddr csr to mtval as raised in issue #31
    * C.SWSP-01.S test updated to fix issue #37

Close: #8 , #31 , #30 , #32 , #33 , #37, #47 , #67 , #96
pawks pushed a commit to pawks/riscv-arch-test that referenced this issue Nov 10, 2022
Changes in this pull-request:

    * restructuring the riscv-test-suite to indicate clearly what is deprecated, wip and usable
      tests.
    * based on the above fixed the directory structure for riscv-targets where-ever applicable. Only
      tested riscvOVPsim and spike.
    * fixed script bugs for spike as well
    * renamed rv32i/I-IO.S to rv32i/I-IO-01.S along with necessary changes to the reference files
      and Makefrag
    * renamed mbadaddr csr to mtval as raised in issue riscv-non-isa#31
    * C.SWSP-01.S test updated to fix issue riscv-non-isa#37

Close: riscv-non-isa#8 , riscv-non-isa#31 , riscv-non-isa#30 , riscv-non-isa#32 , riscv-non-isa#33 , riscv-non-isa#37, riscv-non-isa#47 , riscv-non-isa#67 , riscv-non-isa#96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants