Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why the condition PDTV="0" needs to be added for the iohgatp.mode check? #448

Closed
18772820305 opened this issue Nov 19, 2024 · 1 comment

Comments

@18772820305
Copy link

//13. DC.iohgatp.MODE encoding is not a valid encoding as determined
​    ​//    by <<IOHGATP_MODE_ENC>>
​    ​if​ ( (​DC​->​tc​.​PDTV​ ​==​ ​0​) ​&&​ (​g_reg_file​.​fctl​.​gxl​ ​==​ ​0​) ​&&
​         (​DC​->​iohgatp​.​MODE​ ​!=​ ​IOHGATP_Bare​) ​&&
​         (​DC​->​iohgatp​.​MODE​ ​!=​ ​IOHGATP_Sv39x4​) ​&&
​         (​DC​->​iohgatp​.​MODE​ ​!=​ ​IOHGATP_Sv48x4​) ​&&
​         (​DC​->​iohgatp​.​MODE​ ​!=​ ​IOHGATP_Sv57x4​) ) {
​        ​return​ ​1​;
​    }
​    ​if​ ( (​DC​->​tc​.​PDTV​ ​==​ ​0​) ​&&​ (​g_reg_file​.​fctl​.​gxl​ ​==​ ​1​) ​&&
​         (​DC​->​iohgatp​.​MODE​ ​!=​ ​IOHGATP_Bare​) ​&&
​         (​DC​->​iohgatp​.​MODE​ ​!=​ ​IOHGATP_Sv32x4​) ) {
​        ​return​ ​1​;
​    }

@ved-rivos
Copy link
Collaborator

Thanks for reporting this. The step 13 does not require qualification by PDTV and the code here has an error that is fixed in #449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants