Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Documentation for --enable-qemu-system in README #1622

Open
karaketir16 opened this issue Nov 22, 2024 · 4 comments · May be fixed by #1625
Open

Missing Documentation for --enable-qemu-system in README #1622

karaketir16 opened this issue Nov 22, 2024 · 4 comments · May be fixed by #1625

Comments

@karaketir16
Copy link
Contributor

Hello,

I noticed that the --enable-qemu-system configuration option is not mentioned in the README file. It would be helpful to include information about this option, such as what it does and when it should be used.

Thank you!
@TommyMurphyTM1234
Copy link
Collaborator

Isn't it covered in the QEMU documentation?

If not then the issue should probably be logged upstream?

I don't think that the riscv-gnu-toolchain readme should duplicate instructions/documentation that are (or should be) covered adequately elsewhere.

@karaketir16
Copy link
Contributor Author

it's not about qemu docs, it's a configuration of this toolchain.

riscv-gnu-toolchain/configure

Line 753 in 20f6153

enable_qemu_system

riscv-gnu-toolchain/configure

Line 4639 in 20f6153

if test ${enable_qemu_system+y}

if it's enabled
we set
qemu_targets=riscv64-linux-user,riscv32-linux-user,riscv64-softmmu,riscv32-softmmu
if not enabled
qemu_targets=riscv64-linux-user,riscv32-linux-user

@karaketir16
Copy link
Contributor Author

karaketir16 commented Nov 22, 2024 •
edited
Loading

At least, readme can say like
"use this flag, if you want to enable qemu-system targets"

I need to check configure file to find out this flag exist.

@TommyMurphyTM1234
Copy link
Collaborator

At least, readme can say like "use this flag, if you want to enable qemu-system targets"

I need to check configure file to find out this flag exist.

Please log a PR for this so.

@karaketir16 karaketir16 linked a pull request Nov 25, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add information about --enable-qemu-system karaketir16/riscv-gnu-toolchain
2 participants
@TommyMurphyTM1234 @karaketir16