Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes old rippled integration #88

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Removes old rippled integration #88

merged 4 commits into from
Apr 12, 2024

Conversation

legleux
Copy link
Collaborator

@legleux legleux commented Jan 18, 2024

This can not be merged until XRPLF/rippled#4885 has been integrated and the xrpl Conan package contains those headers.

.github/workflows/build.yml Outdated Show resolved Hide resolved
conanfile.py Outdated Show resolved Hide resolved
@legleux legleux force-pushed the rm-nih branch 2 times, most recently from 0b735fa to 07a4874 Compare February 6, 2024 19:11
@legleux legleux marked this pull request as ready for review February 12, 2024 01:05
@legleux legleux force-pushed the rm-nih branch 3 times, most recently from 06c89d1 to 75c520c Compare February 13, 2024 19:07
@legleux legleux requested a review from oleks-rip February 16, 2024 19:52
oleks-rip
oleks-rip previously approved these changes Feb 26, 2024
Copy link
Collaborator

@oleks-rip oleks-rip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oleks-rip oleks-rip changed the base branch from main to develop February 26, 2024 21:20
@oleks-rip oleks-rip dismissed their stale review February 26, 2024 21:20

The base branch was changed.

Copy link
Collaborator

@oleks-rip oleks-rip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legleux legleux marked this pull request as draft March 6, 2024 02:18
@legleux
Copy link
Collaborator Author

legleux commented Apr 9, 2024

The xrpl Conan package has been fixed as of XRPLF/rippled@c88166e 4/5/23 and this PR works again and is ready.

@legleux legleux marked this pull request as ready for review April 9, 2024 00:48
@legleux legleux requested review from oleks-rip and sappenin April 10, 2024 22:47
@oleks-rip
Copy link
Collaborator

Latest version is good

@legleux legleux merged commit ac28822 into ripple:develop Apr 12, 2024
oleks-rip pushed a commit that referenced this pull request Apr 22, 2024
* Remove old rippled integration

The Conan xrpl package contains all the components necessary to build xbwd now.

* Build packages with libxrpl

* include xxhash

* xbwd does not use xxhash; xxhash dep fixed in rippled-2.2.0-b2
oleks-rip pushed a commit that referenced this pull request May 3, 2024
* Remove old rippled integration

The Conan xrpl package contains all the components necessary to build xbwd now.

* Build packages with libxrpl

* include xxhash

* xbwd does not use xxhash; xxhash dep fixed in rippled-2.2.0-b2
@legleux legleux deleted the rm-nih branch May 15, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants