This repository has been archived by the owner on Sep 2, 2023. It is now read-only.
OAuth login for Ripple Trade #2521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Guys, please don't merge this, work is still in progress, just made a pull request so you can check it out |
| * Sumbit update to blob vault | ||
| */ | ||
|
|
||
| BlobObj.prototype.postUpdate = function(fn) { |
There was a problem hiding this comment.
Please rename fn to callback, that's what we use every other place.
|
@h0vhannes the tests are failing |
|
Comments fixed, tests issue is in progress |
|
Tests issue solved |
id service is responsible for login/logout
Unit tests in exchange.controller.spec.js call blobIsValid with undefined value used as blob object which causes error. This fix adds a type check for userBlob before other checks.
RTB is needed for login tests, so it should be placed in config
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.