Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite search system #916

Open
ckniffen opened this issue Jan 10, 2024 · 0 comments
Open

Rewrite search system #916

ckniffen opened this issue Jan 10, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ckniffen
Copy link
Collaborator

Goals

  • Parallelize the search requests
  • Show more detailed messages when search fails

Current Flow

  • Narrow down paths by regex
    • One possibility: redirect to page
    • More than one possibility: Make requests in order. Ex. For a 64 character hex string lookup transaction and if that fails nft
      • On fail redirect to last thing attempted.

New Flow

  • Narrow down paths by regex
    • One possibility: redirect to page
    • More than one possibility: Make requests in parallel.
      • On failure of all display a message saying what types of items were searched for.
    • Upon a match redirect to matching page

Details

Right now search largely narrows down the query by regex. That was sufficient until NFT searching was added which matches the same criteria as transactions. Amendments hashes match will also match as will most other searches involving hashes as they are often 64 characters.

When no results found show a message detailing all the things attempted and remain on current page. This is a user experience change as it currently takes the user to a 404 page for the last type. This will address #544 where if there is not a transaction or an NFT it directs to the NFT page which is confusing.

Future Work

@ckniffen ckniffen added the enhancement New feature or request label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant