$led Bug: Brackets with tags starting in '$' will not submit properly, players with $ in name get renamed

[VestboyMyst]

This can be seen in SKTAR3 with $led and Rowan SSBM #2 with $man<>boi

when clicking submit the 'Are you sure' dialogue comes up like normal, but clicking submit on that will not do anything

this happens if you're creating a new player or tagging them with an existing alias

another example of a bug with $: http://njssbm.com/#/newjersey/tournaments/57072e64e5925764360756d8
from here http://chaoticneutral.challonge.com/chaoticneutralweeklymelee4_7

Pizza$ was renamed to _cel when submitted

It does not seem to happen with Ko$a (because its in the middle I assume)

[jhertz]

chris, can you test this out more? make a fake tourney on challonge and see if it doesnt work, a minimal testcase would be gr8

[jessemtso]

this bug may not exist anymore. further investigation is required.

[jessemtso]

punting on this for a bit

[jhertz]

confirmed this bug has been fixed.

[VestboyMyst]

$led bug strikes again

https://www.notgarpr.com/#/newjersey/tournaments/57749d38e592572285c2b886

fppssbm.challonge.com/smashheist3

wont let me submit with $legit$ as a new player

[BrandonCookeDev]

So this is still an issue? I'm not sure where this is activating in the code but I can try to look into it

[jhertz]

Apparently it is. We should write a unit test that imports a challonge bracket with lots of ppl with $ in their names and stuff, make sure it works.

Ask @vestboy_myst if its still an issue

Sent from my iPhone

On Jul 2, 2016, at 9:21 AM, Brandon cookiE [email protected] wrote:

So this is still an issue? I'm not sure where this is activating in the code but I can try to look into it

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

[jschnei]

I can't reproduce this locally.

[VestboyMyst]

maybe it was another issue with that bracket? ill try submitting it again

[VestboyMyst]

nope still getting the error on the above bracket url

submit prompt appears but nothing happens when i click it, and $legit$ is always the only entry that is both unchecked and has nothing in its 'player search' field when i first load the page

[jschnei]

So basically, this is happening: angular/angular.js#1463 .

For reasons like this, we should basically never pass names around as keys of dicts/objects (there is a similar problem with json/python for names that start with ".").

[jschnei]

Should be closed by #83. (@VestboyMyst let me know if weird stuff still happens).