-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to pion/webrtc@v3 #2
Comments
@Sean-Der thanks for the update. I will definitely add this to my todo list. |
I am working on it. But I encountered some issue. @Sean-Der Appreciate if you could give me some advice. I think it might be caused by the ICE server configuration. Source code is here https://github.com/ringcentral/ringcentral-softphone-go/tree/dev (dev branch instead of master branch) Output is here:
|
Hey @tylerlong thanks for doing the upgrade, I am not exactly sure yet. Here are the things I am thinking.
|
@Sean-Der in master branch there is the pion/webrtc/v2 version https://github.com/ringcentral/ringcentral-softphone-go/blob/master/answer.go And it worked (not sure it works now but it used to work). So I am wondering what I did wrong in pion v3. I mean if I upgrade everything correctly it should just work. So it's kind of a pion upgrade question. I am reading your list of things and I am trying. I will post update later. Thanks again. |
Output with
|
First I would turn off trickle ICE. That is the only difference I know of. change the code here to be
The instead of can you put Pion finds lots of valid candidate pairs But then it is waiting for the server to select one (and it never happens). if you put
I am not sure :/ |
The very first error/warning is
What does it mean? The subsequent errors may be caused by this one. |
@tylerlong
|
I have made some change bb9d78d I will email your the credential so that you can run the code on your local computer. |
@Sean-Der sent |
Tag v0.7.0 is based on pion/webrtc v3. |
Hey @tylerlong
I just released pion/webrtc@v3 would you be open to accepting a PR upgrading this repo to v3?
I also can add a demo of sending audio as well (and not just playing) we created pion/mediadevices that shows how to capture microphone/webcam in Go.
thanks!
The text was updated successfully, but these errors were encountered: