Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Playwright as a postinstall step #267

Closed
ganderzz opened this issue Aug 15, 2024 · 4 comments
Closed

Remove Playwright as a postinstall step #267

ganderzz opened this issue Aug 15, 2024 · 4 comments

Comments

@ganderzz
Copy link

ganderzz commented Aug 15, 2024

Hey all,

We see periodic flakiness in CI builds because this package has a post-install script in the SDK that installs Playwright. This is not only a bad security practice, but is Playwright being used in the codebase? If so, it should be added as a devDependency so consuming apps don't download Playwright and subsequent dependencies (webkit, firefox, etc).

"postinstall": "npx playwright install",

I am open to making the changes and creating a PR!

@tylerlong
Copy link
Contributor

@embbnux It's introduced here: 5451c5a
We are not using playwright at all. Please remove the postinstall script.
Thanks

@SushilMallRC
Copy link
Contributor

Hi @ganderzz @tylerlong , Changes have been made in the PR #268 and will update here once the new version is released. Thank you for pointing it out.

@SushilMallRC
Copy link
Contributor

A new version, 5.0.3, has been released, which includes a fix for this issue. Closing this issue for now please feel free to reopen or create a new one. Thank You.

@ganderzz
Copy link
Author

Thanks @SushilMallRC !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants