From 62bbeada3d4f84a08714d3bb83e174efd5eb1b8a Mon Sep 17 00:00:00 2001 From: Chen Gong Date: Mon, 23 Dec 2019 13:55:00 +0800 Subject: [PATCH] fix(rime_api.cc): using unchecked fields introduced an ABI breakage https://github.com/rime/librime/pull/328#pullrequestreview-335125464 --- src/rime_api.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/rime_api.cc b/src/rime_api.cc index a13fd4bb2..296fcc65d 100644 --- a/src/rime_api.cc +++ b/src/rime_api.cc @@ -68,7 +68,11 @@ RIME_API void RimeSetup(RimeTraits *traits) { setup_deployer(traits); if (PROVIDED(traits, app_name)) { - SetupLogging(traits->app_name, traits->min_log_level, traits->log_dir); + if (PROVIDED(traits, min_log_level) && PROVIDED(traits, log_dir)) { + SetupLogging(traits->app_name, traits->min_log_level, traits->log_dir); + } else { + SetupLogging(traits->app_name); + } } }