Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime server: log cancelled requests as info messages instead of error messages #1265

Closed
begelundmuller opened this issue Nov 21, 2022 · 0 comments · Fixed by #1330
Closed
Labels
Team:Platform Platform Working Group

Comments

@begelundmuller
Copy link
Contributor

begelundmuller commented Nov 21, 2022

  • A cancelled request is a request where the gRPC handler returns a context.Canceled error
  • The runtime server logging is configured in runtime/server/server.go
  • Off the top of my head, we probably need a custom interceptor that detects requests that return a cancellation error and rewrites it
@begelundmuller begelundmuller added the Team:Platform Platform Working Group label Nov 21, 2022
@begelundmuller begelundmuller changed the title Log cancelled requests as info messages instead of error messages in runtime/server/server.go Runtime server: log cancelled requests as info messages instead of error messages Nov 21, 2022
@pjain1 pjain1 linked a pull request Nov 30, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Platform Platform Working Group
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant