We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In reference to the fix in af4e2ec and the corresponding discussions in #37.
When the overflow happens we end up with a reconnection delay of 0ms, which causes a crazy reconnect spam.
I think the second argument to Math.max should be _max as this overflow happens only when we at max retry delay anyways.
_max
return Math.max(Math.min(ms, _max), _max);
The text was updated successfully, but these errors were encountered:
But, if the overflow doesn't happen, it still uses the _max value, doesn't it? So we may change it with the following condition.
var temp = Math.min(ms, _max); return temp <= 0 ? _max : temp;
Sorry, something went wrong.
409a0de
No branches or pull requests
In reference to the fix in af4e2ec and the corresponding discussions in #37.
When the overflow happens we end up with a reconnection delay of 0ms, which causes a crazy reconnect spam.
I think the second argument to Math.max should be
_max
as this overflow happens only when we at max retry delay anyways.The text was updated successfully, but these errors were encountered: