Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Program frame matching #332

Open
kalzoo opened this issue Jan 17, 2024 · 0 comments · May be fixed by #333
Open

Improve Program frame matching #332

kalzoo opened this issue Jan 17, 2024 · 0 comments · May be fixed by #333
Assignees
@kalzoo

Comments

@kalzoo
Copy link
Contributor

kalzoo commented Jan 17, 2024

  1. Program::get_frames_for_instruction has incorrect, unnecessarily strict lifetime bounds. Its response should be bounded only by the Program, not the instruction.
  2. struct MatchedFrames could use #[derive(Default)] for ergonomics
@kalzoo kalzoo self-assigned this Jan 17, 2024
@kalzoo kalzoo linked a pull request Jan 17, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kalzoo kalzoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Frame Handling Improvements rigetti/quil-rs
1 participant
@kalzoo