From f26e09ab5f178afcb6cc066973fd4439ae7c8085 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andrej=20=C4=8Ci=C5=BEm=C3=A1rik?= Date: Wed, 7 Jul 2021 15:08:53 +0200 Subject: [PATCH 1/2] Updated current stable DotVVM version --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index d25f890656..b636a5b06d 100644 --- a/README.md +++ b/README.md @@ -90,7 +90,7 @@ There is also [dotnet new template](https://www.dotvvm.com/docs/tutorials/how-to | | ASP.NET Core | OWIN | |-------------------------|-----------------------------|-----------------------| -| Current stable version | `DotVVM.AspNetCore 3.0.4` | `DotVVM.Owin 3.0.4` | +| Current stable version | `DotVVM.AspNetCore 3.1.0` | `DotVVM.Owin 3.1.0` | | Minimum runtime version | `.NET Core 2.1` | `.NET 4.5.1` | | Minimum ASP.NET version | `ASP.NET Core 2.1` | `OWIN 3.0.1` | From bfea58cb7281d994da8f73fe89f5d2441399689c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andrej=20=C4=8Ci=C5=BEm=C3=A1rik?= Date: Wed, 7 Jul 2021 15:28:33 +0200 Subject: [PATCH 2/2] Updated contributing.md --- contributing.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/contributing.md b/contributing.md index 645bc88093..29c471bda3 100644 --- a/contributing.md +++ b/contributing.md @@ -20,7 +20,7 @@ First, start by choosing what you'd like to do - you can have a look at [issues Then, you can fork the repo, clone it locally, and you are ready to develop. -Finally, you'll need to create a pull request to the `v3-master` (for DotVVM 3.0) or `master` branch (for DotVVM 2.5) (__we can help with that__), make sure that you have merged the latest changes and that the PR has a readable diff. +Finally, you'll need to create a pull request to the `v4-main` (for DotVVM 4.0) or `main` branch (for DotVVM 3.x) (__we can help with that__), make sure that you have merged the latest changes and that the PR has a readable diff. **Please avoid reformatting documents, refactoring stuff, changing CRLF to LF or tabs to spaces etc. - it makes the PRs difficult to review.** There is definitely room for refactoring or cleanup, but it should be done in a separate PR so it is not messed up with functional changes. @@ -44,13 +44,13 @@ If you plan to work with the DotVVM repository, here is a short manual what you To get started, fork the repository, and clone it on or computer. You can use Visual Studio's Team Explorer window or run `git clone https://github.com//dotvvm.git`. -We are using Visual Studio 2019 or Visual Studio Code. Some projects use .NET Core 2.0 and .NET Core 3.1, so the solution will probably not open in previous versions of Visual Studio. +We are using Visual Studio 2019 or Visual Studio Code. Some projects use .NET Core 2.1, 3.1 and .NET 5.0, so the solution will probably not open in older versions of Visual Studio. Open the `src/DotVVM.sln` solution in Visual Studio, or open the `src` folder in VS Code. Set `Samples/DotVVM.Samples.BasicSamples.AspNetCore` as a startup project and launch it. It should just work - you'll see a page with a long list of samples (they are not often meaningful, they are used by the UI tests to verify all framework features work; however they are great for playing). -If the project does not start, feel free to ask us on [Gitter](https://gitter.im/riganti/dotvvm). For VS Code, launch it from the `src` directory, so it can find the `.vscode/launch.json` and `.vscode/tasks.json` files. You can also try to rebuild `Tests/DotVVM.Framework.Tests.Common` project and run the unit/integration tests - it should complete in few seconds, everything should be green. :) +If the project does not start, feel free to ask us on [Gitter](https://gitter.im/riganti/dotvvm). For VS Code, launch it from the `src` directory, so it can find the `.vscode/launch.json` and `.vscode/tasks.json` files. You can also try to rebuild `Tests/DotVVM.Framework.Tests` project and run the unit/integration tests - it should complete in few seconds, everything should be green. :) Almost everying interesting is in the `DotVVM.Framework` project, except for some base interfaces and attributes in `DotVVM.Core` (so you don't have to reference the entire framework in your bussiess layer, if you just want to suppress serialization or turn on the validation of certain properties).