fix(mix): return valid colors with transparent values at weight extremes #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly handles the edge cases of bug #408. Based on the updated implementation in dart-sass: https://github.com/sass/dart-sass/blob/169178af6c6414d01bc66144b437701057ff3684/lib/src/functions/color.dart#L800-L838
Codecov Report
@@ Coverage Diff @@
## main #409 +/- ##
==========================================
+ Coverage 96.42% 96.44% +0.01%
==========================================
Files 23 23
Lines 196 197 +1
Branches 42 44 +2
==========================================
+ Hits 189 190 +1
Misses 7 7
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 1.2.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #408
Updates the algorithm to correctly handle these edge cases based on the current dart-sass implementation: https://github.com/sass/dart-sass/blob/169178af6c6414d01bc66144b437701057ff3684/lib/src/functions/color.dart#L800-L838